Skip to content

fix(dashboard): remove status list if there are none#59427

Merged
susnux merged 2 commits intomasterfrom
fix/dashboard-list
Apr 7, 2026
Merged

fix(dashboard): remove status list if there are none#59427
susnux merged 2 commits intomasterfrom
fix/dashboard-list

Conversation

@susnux
Copy link
Copy Markdown
Contributor

@susnux susnux commented Apr 3, 2026

If there are no status entries the list must be removed. Its not valid to show an empty list as per accessibility rules: https://www.w3.org/TR/wai-aria-1.2/#mustContain

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@susnux susnux requested a review from a team as a code owner April 3, 2026 15:36
@susnux susnux requested review from julien-nc, nfebe, sorbaugh and szaimen and removed request for a team April 3, 2026 15:36
@susnux susnux requested review from skjnldsv and removed request for sorbaugh April 3, 2026 15:36
@susnux susnux added this to the Nextcloud 34 milestone Apr 3, 2026
@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented Apr 3, 2026

/backport to stable33

@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented Apr 3, 2026

/backport to stable32

Copy link
Copy Markdown
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

- resolves #59334

If there are no status entries the list must be removed.
Its not valid to show an empty list as per accessibility rules:
https://www.w3.org/TR/wai-aria-1.2/#mustContain

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented Apr 7, 2026

/compile

@susnux susnux force-pushed the fix/dashboard-list branch from d87c5b6 to 29628eb Compare April 7, 2026 14:56
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit 053f725 into master Apr 7, 2026
131 checks passed
@susnux susnux deleted the fix/dashboard-list branch April 7, 2026 15:27
@backportbot
Copy link
Copy Markdown

backportbot bot commented Apr 7, 2026

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/59427/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 29628eba 9d705092

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/59427/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Accessibility: container missing necessary children (child nodes in list items)

5 participants